Make opening URLs not fatal if a web browser cannot be opened from the terminal#91
Open
nelsonjchen wants to merge 2 commits intoOptum:masterfrom
Open
Make opening URLs not fatal if a web browser cannot be opened from the terminal#91nelsonjchen wants to merge 2 commits intoOptum:masterfrom
nelsonjchen wants to merge 2 commits intoOptum:masterfrom
Conversation
…e terminal This is useful for environments where a launching a Desktop web browser from the terminal is unavailable or inaccessible. For me, that would WSL out of the box on Windows. A similar pattern can be seen in Google CLIs. Closes Optum#89
|
|
shubydo
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is useful for environments where a launching a Desktop web browser
from the terminal is unavailable or inaccessible.
For me, that would WSL out of the box on Windows. A similar pattern can
be seen in Google CLIs.
Closes #89
Types of changes
Checklist
README.md, inline comments, etc.)CHANGELOG.mdunder a## nextrelease, with a short summary of my changesRelevant Links
Closes #89
Further comments